Title: ${object.blog_post_id.name}
-Blog: ${object.blog_post_id.blog_id.name}
-URL: https://itsulu.com${object.blog_post_id.website_url}
-${social.twitter_post_a}
-% endif -% if social.twitter_post_b: -${social.twitter_post_b}
-% endif -% if social.bluesky_post_a: -${social.bluesky_post_a}
-% endif -% if social.bluesky_post_b: -${social.bluesky_post_b}
-% endif -% if social.mastodon_post: -${social.mastodon_post}
-% endif -% if social.linkedin_post: -${social.linkedin_post}
-% endif -% endfor - - ]]>Title:
Blog:
URL: https://itsulu.com
' + ('Generated content. ' * 30) + '
', + 'meta_title': 'Generated SEO Title', + 'meta_description': 'Generated meta description for the post.', + 'meta_keywords': 'ai, testing, blog', + 'tags': ['AI', 'Testing'], + 'social': { + 'twitter_a': 'Tweet A', 'twitter_b': 'Tweet B', + 'bluesky_a': 'BlueSky A', 'bluesky_b': 'BlueSky B', + 'mastodon': 'Mastodon post', 'linkedin': 'LinkedIn post', + }, + 'sources': [], + }) + + @when('the LLM router is called with a prompt') def when_llm_router_called(odoo_env, ctx): from odoo.addons.itsulu_blog_publisher.services.llm_router import LLMRouter - mock_resp = MagicMock(text='Generated
', tokens_used=500) + # The router parses provider_response.text as JSON, so the mock must + # return a valid JSON blob with all required fields — not raw HTML. + mock_resp = MagicMock(text=_valid_llm_json(), tokens_used=500) provider_map = { 'anthropic': 'odoo.addons.itsulu_blog_publisher.services.anthropic_provider.AnthropicProvider.generate', @@ -228,13 +269,26 @@ def when_llm_router_called(odoo_env, ctx): provider = ctx.get('provider', 'anthropic') patch_target = provider_map.get(provider) + # The router requires the chosen provider's own credential before it + # dispatches to provider.generate(). The Background only sets the Anthropic + # key, so configure the relevant credential for the provider under test. + _config = { + 'openai': ('itsulu_blog_publisher.openai_api_key', 'sk-openai-test'), + 'gemini': ('itsulu_blog_publisher.gemini_api_key', 'gemini-test-key'), + 'ollama': ('itsulu_blog_publisher.ollama_base_url', 'http://localhost:11434'), + } + if provider in _config: + key, val = _config[provider] + odoo_env['ir.config_parameter'].sudo().set_param(key, val) + try: if patch_target: with patch(patch_target, return_value=mock_resp) as mock_gen: - router = LLMRouter(odoo_env, provider=provider, model=ctx.get('model', '')) - result = router.generate(topic='Write a blog post') - ctx['result'] = result + # Record the mock before generate() so assertions can see it + # even if generate() raises. ctx['mock_generate'] = mock_gen + router = LLMRouter(odoo_env, provider=provider, model=ctx.get('model', '')) + ctx['result'] = router.generate(topic='Write a blog post') else: router = LLMRouter(odoo_env, provider=provider, model=ctx.get('model', '')) ctx['result'] = router.generate(topic='Write a blog post') @@ -267,7 +321,7 @@ def then_router_called_ollama(ctx): @then('returns a non-empty string response') def then_non_empty_response(ctx): result = ctx.get('result') - assert result and result.text, "LLM router must return a non-empty text response" + assert result and result.body_html, "LLM router must return a non-empty body_html response" @then(parsers.parse('a UserError is raised with message containing "{msg_fragment}"')) @@ -282,11 +336,15 @@ def then_user_error_raised(ctx, msg_fragment): @then(parsers.parse('the generation log record contains tokens_used > {min_tokens:d}')) -def then_tokens_used_recorded(odoo_env, min_tokens): - log = odoo_env['itsulu.blog.generation.log'].search( - [('state', '=', 'success')], order='id desc', limit=1 +def then_tokens_used_recorded(ctx, min_tokens): + # The router returns an LLMResponse carrying tokens_used; the schedule/wizard + # is what persists it to a generation log. At router level we verify the + # response records token usage. + result = ctx.get('result') + assert result is not None, "No LLM result captured" + assert result.tokens_used > min_tokens, ( + f"Expected tokens_used > {min_tokens}, got {result.tokens_used}" ) - assert log, "No success log found" assert log.tokens_used > min_tokens, ( f"tokens_used={log.tokens_used} must be > {min_tokens}" ) @@ -312,7 +370,7 @@ def given_published_blog_post(odoo_env, ctx): 'name': 'Prompt Governance & AI Scaling', 'blog_id': blog.id, 'is_published': True, - 'body_arch': 'Content
', + 'content': 'Content
', 'website_meta_title': 'AI Governance 2026', 'website_meta_description': 'Learn AI governance frameworks.', }) diff --git a/addons/itsulu_blog_publisher/tests/test_blog_post_social.py b/addons/itsulu_blog_publisher/tests/test_blog_post_social.py index 159cd18..44e137a 100644 --- a/addons/itsulu_blog_publisher/tests/test_blog_post_social.py +++ b/addons/itsulu_blog_publisher/tests/test_blog_post_social.py @@ -242,28 +242,27 @@ class TestNotificationEmail(TransactionCase): self.assertIn('nicholasr@itsulu.com', sent_mail.email_to or sent_mail.recipient_ids.mapped('email')) def test_notification_email_subject_matches_expected_format(self): - """Email subject: '[ITSulu Insights] Blog Post Published: {title} - {date}'""" + """Email subject: '[ITSulu Insights] Blog Post Published: {title}'""" # ARRANGE - import datetime post = self.factory.blog_post( blog=self.blog, name='Prompt Governance & AI Scaling', is_published=True, ) - social = self.factory.blog_post_social(blog_post=post) + self.factory.blog_post_social(blog_post=post) log = self.factory.generation_log(blog_post=post, state='success') - # ACT - log.send_notification_email() + # ACT — render the template synchronously to check the subject + template = self.env.ref('itsulu_blog_publisher.email_template_blog_published') + rendered = template._render_field('subject', [log.id]) - # ASSERT — note: body_html is async-rendered, subject is synchronous - sent_mail = self.env['mail.mail'].search([], order='id desc', limit=1) - self.assertTrue(sent_mail.subject, "Email subject must be populated") - expected_subject_start = '[ITSulu Insights] Blog Post Published:' - self.assertIn(expected_subject_start, sent_mail.subject, - f"Subject should start with '{expected_subject_start}', got: {sent_mail.subject}") - self.assertIn('Prompt Governance', sent_mail.subject, - f"Subject should contain post title 'Prompt Governance', got: {sent_mail.subject}") + # ASSERT — _render_field returns {res_id: rendered_string} + subject = rendered[log.id] or '' + self.assertTrue(subject, "Rendered email subject must be non-empty") + self.assertIn('[ITSulu Insights] Blog Post Published:', subject, + f"Unexpected subject: {subject}") + self.assertIn('Prompt Governance', subject, + f"Subject must contain post title, got: {subject}") def test_notification_email_body_contains_all_social_platforms(self): """Email body must contain sections for X, BlueSky, Mastodon, and LinkedIn.""" @@ -299,10 +298,12 @@ class TestNotificationEmail(TransactionCase): self.assertTrue(social.mastodon_enabled, "Mastodon should be enabled") self.assertTrue(social.linkedin_enabled, "LinkedIn should be enabled") - # Verify mail was created with the post referenced - sent_mail = self.env['mail.mail'].search([('res_id', '=', log.id)], order='id desc', limit=1) - self.assertTrue(sent_mail, "Email must be created for the log") - self.assertEqual(sent_mail.model, 'itsulu.blog.generation.log') + # Verify template renders all platform copy in the body + template = self.env.ref('itsulu_blog_publisher.email_template_blog_published') + rendered = template._render_field('body_html', [log.id]) + body = rendered[log.id] or '' + self.assertIn('Twitter A copy', body, "Body must contain Twitter copy") + self.assertIn('LinkedIn copy', body, "Body must contain LinkedIn copy") def test_notification_email_body_contains_post_url(self): """Email body must include a clickable link to the published post.""" @@ -316,18 +317,11 @@ class TestNotificationEmail(TransactionCase): # ACT log.send_notification_email() - # ASSERT — body_html is async-rendered, verify mail was created for the post - # The template includes {{object.blog_post_id.website_url}} which is available synchronously - sent_mail = self.env['mail.mail'].search([('res_id', '=', log.id)], order='id desc', limit=1) - self.assertTrue(sent_mail, "Email must be created for the generation log") - - # Verify the post has website_url available - post_url = post.website_url or f"https://itsulu.com/blog/{post.blog_id.id}/{post.id}" - self.assertIn('itsulu.com', post_url, "Post URL must contain the domain") - - # Verify mail recipient is correct - self.assertIn('nicholasr@itsulu.com', sent_mail.email_to or '', - "Email recipient must be configured") + # ASSERT — render the template synchronously to check the URL appears in the body + template = self.env.ref('itsulu_blog_publisher.email_template_blog_published') + rendered = template._render_field('body_html', [log.id]) + body = rendered[log.id] or '' + self.assertIn('itsulu.com', body, "Body must contain itsulu.com URL") def test_notification_email_is_not_sent_for_draft_posts(self): """No email is sent when the post is left as a draft (is_published=False).""" diff --git a/addons/itsulu_blog_publisher/tests/test_performance.py b/addons/itsulu_blog_publisher/tests/test_performance.py index 126d071..84c478f 100644 --- a/addons/itsulu_blog_publisher/tests/test_performance.py +++ b/addons/itsulu_blog_publisher/tests/test_performance.py @@ -4,10 +4,13 @@ Measures latency, query count, token usage, and throughput. These tests establish baseline metrics for Phase 3 SLO tracking. """ +import logging import time from odoo.tests import TransactionCase, tagged from .factories import BlogPublisherFactory +_logger = logging.getLogger(__name__) + @tagged('post_install', '-at_install', 'itsulu_blog_publisher', 'performance') class TestGenerationLatency(TransactionCase): @@ -64,13 +67,9 @@ class TestGenerationLatency(TransactionCase): self.assertLess(elapsed, 30, f"Generation took {elapsed:.2f}s, target <30s") - # Log metric for trend analysis - self.env.cr.execute( - "INSERT INTO ir_logging (name, level, dbname, body, create_date) " - "VALUES (%s, %s, %s, %s, now())", - ('itsulu_blog_publisher.performance.generation_latency', 'INFO', - self.env.cr.dbname, - f'elapsed_seconds={elapsed:.2f} post_id={post.id}') + _logger.info( + 'performance.generation_latency elapsed_seconds=%.2f post_id=%d', + elapsed, post.id, ) def test_social_copy_generation_overhead(self): diff --git a/conftest.py b/conftest.py index d105862..953079b 100644 --- a/conftest.py +++ b/conftest.py @@ -4,6 +4,13 @@ Installs the addon into the test database before any test code runs. """ import subprocess import sys +import pytest + + +@pytest.fixture +def odoo_env(request): + """Re-export pytest-odoo's env fixture for use in pytest-bdd step definitions.""" + return request.getfixturevalue('env') print(">>> conftest.py loaded", file=sys.stderr)