Ignore and log GitHub commit status creation errors

This commit is contained in:
Stéphane Bidoul 2023-08-31 21:04:04 +02:00
parent 02d7fafb21
commit 9051373653

View file

@ -1,3 +1,4 @@
import logging
from enum import Enum from enum import Enum
from typing import Any from typing import Any
@ -7,6 +8,8 @@ from pydantic import BaseModel, validator
from .exceptions import NotFoundOnGitHub from .exceptions import NotFoundOnGitHub
from .settings import settings from .settings import settings
_logger = logging.getLogger(__name__)
async def _github_request(method: str, url: str, json: Any = None) -> Any: async def _github_request(method: str, url: str, json: Any = None) -> Any:
async with httpx.AsyncClient() as client: async with httpx.AsyncClient() as client:
@ -67,6 +70,7 @@ async def notify_status(
if settings.disable_commit_statuses: if settings.disable_commit_statuses:
return return
# https://docs.github.com/en/rest/reference/repos#create-a-commit-status # https://docs.github.com/en/rest/reference/repos#create-a-commit-status
try:
await _github_request( await _github_request(
"POST", "POST",
f"/repos/{repo}/statuses/{sha}", f"/repos/{repo}/statuses/{sha}",
@ -76,3 +80,8 @@ async def notify_status(
"context": "runboat/build", "context": "runboat/build",
}, },
) )
except httpx.HTTPStatusError as e:
_logger.error(
f"Failed to post GitHub commit status (code {e.response.status_code}):\n"
f"{e.response.text}"
)