From a5e8185abd4cd7477e6c4c3853a1f61e119a14ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= Date: Fri, 5 Nov 2021 10:08:39 +0100 Subject: [PATCH] Rename method for clarity --- src/runboat/api.py | 4 ++-- src/runboat/controller.py | 2 +- src/runboat/webhooks.py | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/runboat/api.py b/src/runboat/api.py index fdfe413..93183ac 100644 --- a/src/runboat/api.py +++ b/src/runboat/api.py @@ -80,7 +80,7 @@ async def builds(repo: Optional[str] = None): async def trigger_branch(repo: str, branch: str): """Trigger build for a branch.""" branch_info = await github.get_branch_info(repo, branch) - await controller.deploy_or_delay_start( + await controller.deploy_or_start( repo=branch_info.repo, target_branch=branch_info.name, pr=None, @@ -95,7 +95,7 @@ async def trigger_branch(repo: str, branch: str): async def trigger_pull(repo: str, pr: int): """Trigger build for a pull request.""" pull_info = await github.get_pull_info(repo, pr) - await controller.deploy_or_delay_start( + await controller.deploy_or_start( repo=pull_info.repo, target_branch=pull_info.target_branch, pr=pull_info.number, diff --git a/src/runboat/controller.py b/src/runboat/controller.py index dd2ea52..6626f54 100644 --- a/src/runboat/controller.py +++ b/src/runboat/controller.py @@ -73,7 +73,7 @@ class Controller: def undeploying(self) -> int: return self.db.count_by_status(BuildStatus.undeploying) - async def deploy_or_delay_start( + async def deploy_or_start( self, repo: str, target_branch: str, pr: int | None, git_commit: str ) -> None: build = self.db.get_for_commit( diff --git a/src/runboat/webhooks.py b/src/runboat/webhooks.py index c45c409..0088156 100644 --- a/src/runboat/webhooks.py +++ b/src/runboat/webhooks.py @@ -29,7 +29,7 @@ async def receive_payload( if x_github_event == "pull_request": if action in ("opened", "synchronize"): background_tasks.add_task( - controller.deploy_or_delay_start, + controller.deploy_or_start, repo=repo, target_branch=payload["pull_request"]["base"]["ref"], pr=payload["pull_request"]["number"], @@ -37,7 +37,7 @@ async def receive_payload( ) elif x_github_event == "push": background_tasks.add_task( - controller.deploy_or_delay_start, + controller.deploy_or_start, repo=repo, target_branch=payload["ref"].split("/")[-1], pr=None,