From b38f5b2a94451bf798b593d6028d16b1b13c4649 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?St=C3=A9phane=20Bidoul?= <stephane.bidoul@gmail.com>
Date: Sat, 20 Nov 2021 17:29:49 +0100
Subject: [PATCH] Add an initializing status

It is more explicit that "starting", since now builds
do not start automatically after initialization.
---
 src/runboat/controller.py |  4 ++--
 src/runboat/models.py     | 11 ++++++++---
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/runboat/controller.py b/src/runboat/controller.py
index 23b06ff..d6c5b66 100644
--- a/src/runboat/controller.py
+++ b/src/runboat/controller.py
@@ -20,8 +20,8 @@ class Controller:
       initializer, stopper and undeployer when the state of deployments change.
     - The 'job_watcher' listens to kubernetes events on jobs, to maintain the
       runboat/init-status annotation on deployments, and act on such events (such as
-      starting when an initialization succeeded or undeploying when a cleanup
-      succeeded).
+      changing the init-status when an initialization succeeded or failed or undeploying
+      when a cleanup succeeded).
     - The 'initializer' starts initialization jobs for deployment that have been marked
       with 'runboat/init-status=todo', while making sure that the maximum number of
       deployments initializing concurrently does not exceed the limit.
diff --git a/src/runboat/models.py b/src/runboat/models.py
index afe8aff..7b9ed2e 100644
--- a/src/runboat/models.py
+++ b/src/runboat/models.py
@@ -23,7 +23,8 @@ class BuildEvent(str, Enum):
 class BuildStatus(str, Enum):
     stopped = "stopped"  # initialization succeeded and 0 replicas
     stopping = "stopping"  # 0 desired replicas but some are still running
-    starting = "starting"  # to initialize or initializing or scaling up
+    initializing = "initializing"  # to initialize or initializing
+    starting = "starting"  # scaling up
     started = "started"  # running
     failed = "failed"  # initialization failed
     undeploying = "undeploying"  # undeploying, will be deleted after cleanup
@@ -101,7 +102,7 @@ class Build(BaseModel):
             return BuildStatus.undeploying
         init_status = deployment.metadata.annotations["runboat/init-status"]
         if init_status in (BuildInitStatus.todo, BuildInitStatus.started):
-            return BuildStatus.starting
+            return BuildStatus.initializing
         elif init_status == BuildInitStatus.failed:
             return BuildStatus.failed
         elif init_status == BuildInitStatus.succeeded:
@@ -199,7 +200,11 @@ class Build(BaseModel):
 
     async def start(self) -> None:
         """Start build if init succeeded, or reinitialize if failed."""
-        if self.status in (BuildStatus.started, BuildStatus.starting):
+        if self.status in (
+            BuildStatus.initializing,
+            BuildStatus.started,
+            BuildStatus.starting,
+        ):
             _logger.info(
                 f"Ignoring start command for {self} "
                 "that is already started or starting."