itsulu/runboat
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rename method for clarity

Browse source
This commit is contained in:
Stéphane Bidoul 2021-11-05 10:08:39 +01:00
parent 3c1b4b3fb2
commit a5e8185abd
No known key found for this signature in database
GPG key ID: BCAB2555446B5B92
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/runboat/api.py
View file

@ -80,7 +80,7 @@ async def builds(repo: Optional[str] = None):
async def trigger_branch(repo: str, branch: str): async def trigger_branch(repo: str, branch: str):
"""Trigger build for a branch.""" """Trigger build for a branch."""
branch_info = await github.get_branch_info(repo, branch) branch_info = await github.get_branch_info(repo, branch)
await controller.deploy_or_delay_start( await controller.deploy_or_start(
repo=branch_info.repo, repo=branch_info.repo,
target_branch=branch_info.name, target_branch=branch_info.name,
pr=None, pr=None,
@ -95,7 +95,7 @@ async def trigger_branch(repo: str, branch: str):
async def trigger_pull(repo: str, pr: int): async def trigger_pull(repo: str, pr: int):
"""Trigger build for a pull request.""" """Trigger build for a pull request."""
pull_info = await github.get_pull_info(repo, pr) pull_info = await github.get_pull_info(repo, pr)
await controller.deploy_or_delay_start( await controller.deploy_or_start(
repo=pull_info.repo, repo=pull_info.repo,
target_branch=pull_info.target_branch, target_branch=pull_info.target_branch,
pr=pull_info.number, pr=pull_info.number,

2
src/runboat/controller.py
View file

@ -73,7 +73,7 @@ class Controller:
def undeploying(self) -> int: def undeploying(self) -> int:
return self.db.count_by_status(BuildStatus.undeploying) return self.db.count_by_status(BuildStatus.undeploying)
async def deploy_or_delay_start( async def deploy_or_start(
self, repo: str, target_branch: str, pr: int | None, git_commit: str self, repo: str, target_branch: str, pr: int | None, git_commit: str
) -> None: ) -> None:
build = self.db.get_for_commit( build = self.db.get_for_commit(

4
src/runboat/webhooks.py
View file

@ -29,7 +29,7 @@ async def receive_payload(
if x_github_event == "pull_request": if x_github_event == "pull_request":
if action in ("opened", "synchronize"): if action in ("opened", "synchronize"):
background_tasks.add_task( background_tasks.add_task(
controller.deploy_or_delay_start, controller.deploy_or_start,
repo=repo, repo=repo,
target_branch=payload["pull_request"]["base"]["ref"], target_branch=payload["pull_request"]["base"]["ref"],
pr=payload["pull_request"]["number"], pr=payload["pull_request"]["number"],
@ -37,7 +37,7 @@ async def receive_payload(
) )
elif x_github_event == "push": elif x_github_event == "push":
background_tasks.add_task( background_tasks.add_task(
controller.deploy_or_delay_start, controller.deploy_or_start,
repo=repo, repo=repo,
target_branch=payload["ref"].split("/")[-1], target_branch=payload["ref"].split("/")[-1],
pr=None, pr=None,